Hallo Klaus
summary.vdr from Master-Timer is not shown correctly.
Example what they look like (enriched with infos from tvmovie2vdr). I would not expect that VDR parses Title or Subtitle ;), but it would be nice if it would just show everything in the file :
ID: "41615360"
Title: "Bean"
Subtitle: "Der ultimative Katastrophenfilm"
Description: "Spielfilm/Komödie, GB/USA, 1997, FSK: 6 (Bean) [ DolbyDigital ]
Kurzkritik: Mr. Bean ist voll in seinem Element!
Action ** / Thrill * / Humor *** / Allgemein ***
Museumswärter sorgt in L.A. für Chaos. Nach einer Millionenspende kann endlich ein amerikanisches Kunstwerk vom Pariser Musée D'Orsay freigekauft und in die Grierson Gallery nach Los Angeles zurückgebracht werden. Um dieses Ereignis gebührend zu feiern, hat man einen Kunstexperten von der Royal National Gallery of England eingeladen. Dr. Bean soll eine feierliche Rede halten - ein grober Fehler, wie sich zeigt. Denn Bean, in Wirklichkeit der Museumswärter, sorgt überall nur für Chaos und Katastrophen!
Regie: Mel Smith Darsteller: Rowan Atkinson (Mr. Bean), Harris Yulin (George Grierson), Peter MacNicol (David Langley), Pamela Reed (Alison Langley), Burt Reynolds (Gen. Newton), Johnny Galecki (Stingo Wheelie), Peter Egan (Lord Walton), John Mills (Vorsitzender), Peter Capaldi (Gareth)"
Greetings Christian Jacobsen
christian jacobsen wrote:
Hallo Klaus
Please always start a new thread - don't reply to the release note.
Well, I have only tested with VDR's own summary files ;-)
Please try if this helps:
--- recording.c 2005/05/29 11:16:57 1.107 +++ recording.c 2005/06/03 13:15:54 @@ -480,7 +480,7 @@ char *data[3] = { NULL }; cReadLine ReadLine; char *s; - while ((s = ReadLine.Read(f)) != NULL && line < 3) { + while ((s = ReadLine.Read(f)) != NULL) { if (*s) { if (data[line]) { int len = strlen(s); @@ -492,7 +492,7 @@ else data[line] = strdup(s); } - else + else if (line < 2) line++; } fclose(f);
The first two lines (separated by an empty line) will be used as Title and ShortText, and the rest (again, separated by an empty line) will be put into the Description. With Master Timer's format this will still be somewhat messy, since in your example it would interpret
ID: "41615360"
as the Title and
Title: "Bean"
as the ShortText, but at least all the rest should make it into the Description.
Maybe Master Timer should have written its summary.conf the way VDR did ;-)
Klaus
Klaus Schmidinger wrote:
Maybe Master Timer should have written its summary.conf the way VDR did ;-)
I've "invented" that format >4 years ago and as i NEVER ever programmed a Timer via VDR since this >4 years, i can't even remember what format VDR uses. :-) I guess i should take the time to invent a new format that is compatible with both "old" (1.2.0 - 1.3.24) and "new" (1.3.25 - <x>) VDR.
Btw. Could you/someone provide a few examples of VDR-created timers & info.vdr-files (best including the snipped from epg.data) from 1.3.25?
Matthias Schniedermeyer wrote:
The old summary.vdr files were written as
--------------------------- Title
ShortText
Description ---------------------------
where Title and ShortText were single lines, and Description could be several lines. Both ShortText and Description were optional.
The new info.vdr format is described in vdr.5 and looks like this:
--------------------------- C S19.2E-1-1079-28007 T nano S Die Welt von morgen D U.a. mit folgenden Themen: Verbrennen statt verkippen Neues Gesetz für den Restmüll Spritze gegen Schuppenflechte Neuer Wirkstoff blockiert das Immunsystem Formel für den Frühling Die Mathematik des Pflanzenwachstums Deutschland, 2005 X 2 01 deu Mono X 2 01 deu mono/2-Kanal X 1 01 deu 4:3 ---------------------------
Klaus
Klaus Schmidinger wrote:
(Forword: "Description" is optional in Master-Timer, personally i don't like them in my timers, so i don't have them)
So for the timer-(summary/info)-field it should be enough to replace the "||" Between the ID & Title with a " ", resulting in
old: ID: "904527872"||Title: "Alias - Die Agentin"||Subtitle: "Erpressung"
new: ID: "904527872" Title: "Alias - Die Agentin"||Subtitle: "Erpressung"
But maybe i should change to a more "Eyefriendly" and shorter format. What do you think of this? Alias - Die Agentin (MT-ID:904527872)||Erpressung optionally appending: ||<Description>
That would match the VDR-Format and be much less intrusive (only difference to VDR-format beeing the "(MT-ID:<id>)"-string) than the current format. :-)
Klaus Schmidinger wrote:
Any Master-Timer Users already using a 1.3.25 VDR and using the "done" functionality that want's to beta-test this change?
Bis denn
Klaus Schmidinger wrote:
Actually this might be even better, since it preserves empty lines in the description:
--- recording.c 2005/05/29 11:16:57 1.107 +++ recording.c 2005/06/04 11:31:24 @@ -480,8 +480,8 @@ char *data[3] = { NULL }; cReadLine ReadLine; char *s; - while ((s = ReadLine.Read(f)) != NULL && line < 3) { - if (*s) { + while ((s = ReadLine.Read(f)) != NULL) { + if (*s || line > 1) { if (data[line]) { int len = strlen(s); len += strlen(data[line]) + 1;
Klaus