Hi,
I was hunting a bug in VDRAdmin when I stumbled on "confusing" behaviour in VDR1.3.34:
Programming a timer using "newt ..." and a very long summary leads to "line too long" error message. Made some debugging and it seems that a line can be up to 10239 characters. So I shortened the "newt" call to 10239 and VDR accepted it. Reviewed to timer in the VDR OSD and it showed up. Later I had to restart VDR and it refused to read timers.conf! Then I manually edited timers.conf until VDR accepted it. I had to shorten the "newt" call to 10218 characters to get all working. Looking at VDR'S source the parse buffer is 10k (10240 byte).
Are there some circumstances I don't get? Please enlighten me!
Regards, Andreas
On Wednesday 12 October 2005 13:09, Andreas Mair wrote:
Hi,
I was hunting a bug in VDRAdmin when I stumbled on "confusing" behaviour in VDR1.3.34:
Programming a timer using "newt ..." and a very long summary leads to "line too long" error message. Made some debugging and it seems that a line can be up to 10239 characters. So I shortened the "newt" call to 10239 and VDR accepted it. Reviewed to timer in the VDR OSD and it showed up. Later I had to restart VDR and it refused to read timers.conf! Then I manually edited timers.conf until VDR accepted it. I had to shorten the "newt" call to 10218 characters to get all working. Looking at VDR'S source the parse buffer is 10k (10240 byte).
Had this too (using master-timer) - simply increased the parse buffer to make it vanish, though there might be a better way to handle this.
Hi,
On Wednesday 12 October 2005 14:43, Guido Fiala wrote:
On Wednesday 12 October 2005 13:09, Andreas Mair wrote:
Hi,
I was hunting a bug in VDRAdmin when I stumbled on "confusing" behaviour in VDR1.3.34:
Programming a timer using "newt ..." and a very long summary leads to "line too long" error message. Made some debugging and it seems that a line can be up to 10239 characters. So I shortened the "newt" call to 10239 and VDR accepted it. Reviewed to timer in the VDR OSD and it showed up. Later I had to restart VDR and it refused to read timers.conf! Then I manually edited timers.conf until VDR accepted it. I had to shorten the "newt" call to 10218 characters to get all working. Looking at VDR'S source the parse buffer is 10k (10240 byte).
Had this too (using master-timer) - simply increased the parse buffer to make it vanish, though there might be a better way to handle this.
Well, this would mean that every VDRAdmin user must increase the parse buffer or (s)he might get problems. I prefer to send only valid command lines to the SVDRP.
Regards, Andreas
Andreas Mair wrote:
Hi,
I was hunting a bug in VDRAdmin when I stumbled on "confusing" behaviour in VDR1.3.34:
Programming a timer using "newt ..." and a very long summary leads to "line too long" error message. Made some debugging and it seems that a line can be up to 10239 characters. So I shortened the "newt" call to 10239 and VDR accepted it. Reviewed to timer in the VDR OSD and it showed up. Later I had to restart VDR and it refused to read timers.conf! Then I manually edited timers.conf until VDR accepted it. I had to shorten the "newt" call to 10218 characters to get all working. Looking at VDR'S source the parse buffer is 10k (10240 byte).
Are there some circumstances I don't get? Please enlighten me!
Regards, Andreas
Are you writing the entire film's script into the timer's 'summary'?
Even in my wildest dreams I would never have expected that 10KB would _ever_ be too little for this...
Are you really sure this is a good thing to do?
Klaus
On Wednesday 12 October 2005 15:26, Klaus Schmidinger wrote:
Are you writing the entire film's script into the timer's 'summary'?
Even in my wildest dreams I would never have expected that 10KB would _ever_ be too little for this...
Are you really sure this is a good thing to do?
Nevertheless, the max length should be the same at all places, shouldn't it? ;-)
Greetings, Sascha
On Wed, 12 Oct 2005, Sascha Volkenandt (SV) wrote:
On Wednesday 12 October 2005 15:26, Klaus Schmidinger wrote:
Are you writing the entire film's script into the timer's 'summary'?
Even in my wildest dreams I would never have expected that 10KB would _ever_ be too little for this...
Are you really sure this is a good thing to do?
Nevertheless, the max length should be the same at all places, shouldn't it? ;-)
I guess what happened is that VDR replaced the channel number (wich is just one up to four-five digits) by the unique channel descriptor used in timers.conf. so the line became longer when it was written to file.
when read again, it was rejected...
Sergei
Hi,
On Wednesday 12 October 2005 15:26, Klaus Schmidinger wrote:
Andreas Mair wrote:
Hi,
I was hunting a bug in VDRAdmin when I stumbled on "confusing" behaviour in VDR1.3.34:
Programming a timer using "newt ..." and a very long summary leads to "line too long" error message. Made some debugging and it seems that a line can be up to 10239 characters. So I shortened the "newt" call to 10239 and VDR accepted it. Reviewed to timer in the VDR OSD and it showed up. Later I had to restart VDR and it refused to read timers.conf! Then I manually edited timers.conf until VDR accepted it. I had to shorten the "newt" call to 10218 characters to get all working. Looking at VDR'S source the parse buffer is 10k (10240 byte).
Are there some circumstances I don't get? Please enlighten me!
Regards, Andreas
Are you writing the entire film's script into the timer's 'summary'?
Even in my wildest dreams I would never have expected that 10KB would _ever_ be too little for this...
Are you really sure this is a good thing to do?
You're absolutely right. It's not that I want to do it, but there had been a bug report for VDRAdmin that some timers couldn't be programmed due to long summaries. After shortening the summary the timer got programmed. I simply tried to locate the bug and I saw that VDR behaviour. That's all.
And I really think that 10KB is enough. But OTOH: VDR should be able to read what it writes...
Regards, Andreas
-
Andreas Mair -
Guido Fiala -
Klaus Schmidinger -
Sascha Volkenandt -
Sergei Haller